Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updatecli: it uses an env variable #36149

Closed
wants to merge 1 commit into from
Closed

updatecli: it uses an env variable #36149

wants to merge 1 commit into from

Conversation

v1v
Copy link
Member

@v1v v1v commented Jul 25, 2023 •
edited
Loading

What does this PR do?

Remove the file from the auto-golang bump

Why is it important?

It uses an env variable instead.

Test

As long as gh and updatecli are installed then

$ GIT_USER=You_User \
  GIT_EMAIL=Your_Email \
  GITHUB_TOKEN=GITHUB_TOKEN=$(gh auth token) \
  JOB_URL=nop \
  updatecli diff --config .ci/bump-golang.yml

See #35931 (comment)

@v1v v1v requested a review from a team as a code owner July 25, 2023 08:20
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label Team:Automation Label for the Observability productivity team and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jul 25, 2023
@mergify
Copy link
Contributor

mergify bot commented Jul 25, 2023

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @v1v? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@mergify mergify bot assigned v1v Jul 25, 2023
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-07-25T08:20:39.356+0000

  • Duration: 13 min 22 sec

Test stats 🧪

Test Results
Failed 0
Passed 3
Skipped 0
Total 3

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@mergify
Copy link
Contributor

mergify bot commented Aug 4, 2023

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b fix/update-cli-golang-bumps upstream/fix/update-cli-golang-bumps
git merge upstream/main
git push upstream fix/update-cli-golang-bumps

@v1v
Copy link
Member Author

v1v commented Aug 7, 2023

#36234 solved this issue

@v1v v1v closed this Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdner rdner rdner approved these changes

@fearful-symmetry fearful-symmetry Awaiting requested review from fearful-symmetry fearful-symmetry is a code owner automatically assigned from elastic/elastic-agent-data-plane

Assignees

@v1v v1v

Labels
Team:Automation Label for the Observability productivity team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@v1v @elasticmachine @rdner